fix(ecr): Generate valid CloudFormation for imageScanOnPush (aws#13420)

fix aws#13418: Update ECR construct to generate valid CloudFormation when enabling `imageScanOnPush` ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
cornerwings · Mar 8, 2021 · 0979ea4 · 0979ea4
1 parent e6f45f2
commit 0979ea4
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/packages/@aws-cdk/aws-ecr/lib/repository.ts b/packages/@aws-cdk/aws-ecr/lib/repository.ts
@@ -450,7 +450,7 @@ export class Repository extends RepositoryBase {
       repositoryPolicyText: Lazy.any({ produce: () => this.policyDocument }),
       lifecyclePolicy: Lazy.any({ produce: () => this.renderLifecyclePolicy() }),
       imageScanningConfiguration: !props.imageScanOnPush ? undefined : {
-        scanOnPush: true,
+        ScanOnPush: true,
       },
     });
 

diff --git a/packages/@aws-cdk/aws-ecr/test/integ.imagescan.expected.json b/packages/@aws-cdk/aws-ecr/test/integ.imagescan.expected.json
@@ -4,7 +4,7 @@
       "Type": "AWS::ECR::Repository",
       "Properties": {
         "ImageScanningConfiguration": {
-          "scanOnPush": true
+          "ScanOnPush": true
         }
       },
       "UpdateReplacePolicy": "Delete",
@@ -87,4 +87,4 @@
       }
     }
   }
-}
+}
diff --git a/packages/@aws-cdk/aws-ecr/test/test.repository.ts b/packages/@aws-cdk/aws-ecr/test/test.repository.ts
@@ -38,7 +38,7 @@ export = {
     // THEN
     expect(stack).to(haveResource('AWS::ECR::Repository', {
       ImageScanningConfiguration: {
-        scanOnPush: true,
+        ScanOnPush: true,
       },
     }));
     test.done();