Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: decodeConfig was passed incorrectly to decode #502

Merged
merged 1 commit into from
Dec 21, 2022
Merged

fix: decodeConfig was passed incorrectly to decode #502

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/shared/decodeImageFrame.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import decodeJPEGLS from './decoders/decodeJPEGLS.js';
import decodeJPEG2000 from './decoders/decodeJPEG2000.js';
import decodeHTJ2K from './decoders/decodeHTJ2K.js';
import scaleArray from './scaling/scaleArray.js';
import { getOptions } from '../imageLoader/internal/options.js';

function decodeImageFrame(
imageFrame,
Expand Down Expand Up @@ -140,17 +141,17 @@ function decodeImageFrame(

decodePromise
.then((imageFrame) => {
callbackFn(
postProcessDecodedPixels(imageFrame, options, start, decodeConfig)
);
callbackFn(postProcessDecodedPixels(imageFrame, options, start));
})
.catch((err) => {
throw err;
});
}

function postProcessDecodedPixels(imageFrame, options, start, decodeConfig) {
const { use16BitDataType } = decodeConfig;
function postProcessDecodedPixels(imageFrame, options, start) {
const {
decodeConfig: { use16BitDataType },
} = getOptions();

const shouldShift =
imageFrame.pixelRepresentation !== undefined &&
Expand Down