fix: toolType to toolName #991
Conversation
Codecov Report
@@ Coverage Diff @@
## master #991 +/- ##
=======================================
Coverage 13.05% 13.05%
=======================================
Files 223 223
Lines 7370 7370
Branches 1191 1191
=======================================
Hits 962 962
Misses 5402 5402
Partials 1006 1006
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #991 +/- ##
=======================================
Coverage 13.11% 13.11%
=======================================
Files 223 223
Lines 7375 7375
Branches 1194 1194
=======================================
Hits 967 967
Misses 5400 5400
Partials 1008 1008
Continue to review full report at Codecov.
|
|
|
||
| const eventType = EVENTS.MEASUREMENT_ADDED; | ||
| const eventData = { | ||
| toolType, | ||
| toolName, |
There was a problem hiding this comment.
This is a breaking api change. I'm happy to change this as its technically correct, although we should have a deprecated alias with toolType Either that or we PR this to v4 only. What do you think @dannyrb ?
There was a problem hiding this comment.
I think v4 is coming down the pipe soon enough that we should just do it there, and make a note of it in our breaking changes / migration guide.
|
@jlopes90 can you make this same change on our |
At this moment, I'm busy, I have things to do with my project. So I'll see if I can. |
|
Sorry, I was wrong to click close pull request |
|
Can I change in vNext branch? |
|
@dannyrb What was the verdict on this? It flew over out radar for 4.0, and is still breaking as we discussed, shall we hotfix it in whilst 4.0 usage still isn't too mainstream (< 4 days old)? |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Fix
What is the current behavior? (You can also link to an open issue here)
Measurement Added and Removed, toolType change to toolName.
Because Modified and Completed is toolName.
What is the new behavior (if this is a feature change)?
No
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information:
No