-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/event dispatch locking changes #836
Feature/event dispatch locking changes #836
Conversation
…lti-part tool's loop. Added a new flag, isMultiPartTool to tools, and a global state trigger you may set called isMultiPartToolActive. If this is true, only non-annotation tools may be used whilst you are in a multi-part tool's event loop. re cornerstonejs#833
Codecov Report
@@ Coverage Diff @@
## master #836 +/- ##
==========================================
- Coverage 10.81% 10.78% -0.03%
==========================================
Files 210 211 +1
Lines 6776 6813 +37
Branches 1075 1088 +13
==========================================
+ Hits 733 735 +2
- Misses 5095 5118 +23
- Partials 948 960 +12
Continue to review full report at Codecov.
|
TODO:
|
For a similar tool in Slicer it was helpful to allow scrolling in the middle of drawing. It lets you better understand the 3D nature of the outline. What I did was display the polyline-so-far as a dashed line to indicate it's not active. The line goes back to solid when you are back on the slice where you started. |
@pieper Hmm, that makes sense. With the current way I guess we could save a reference to the WIP toolData on the tool itself when start drawing, then in the Then you delete the reference on the tool when the annotation is complete. |
The way the current Slicer Segment Editor operates is to let you scroll while keeping your WIP drawing and then applying it to the slice where you complete it. This works pretty well too and might be easier and more logical to implement. Basically you would just move the tool state to the new image. |
Following this discussion I won't block scroll from being used. Any expansion to the freehand tool UI to improve the UX whilst scrolling would be introduced in a subsequent PR. |
🎉 This PR is included in version 3.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
feat(Event Dispatchers): Can now use non-annotation tools during a multi-part tool's loop.
Added a new flag, isMultiPartTool to tools, and a global state trigger you may set called isMultiPartToolActive. If this is true, only non-annotation tools may be used whilst you are in a multi-part tool's event loop.
re #833