Protect against null viewport pixelSpacing
#826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## feature/overlay-tool #826 +/- ##
========================================================
- Coverage 10.77% 10.77% -0.01%
========================================================
Files 210 210
Lines 6802 6803 +1
Branches 1075 1075
========================================================
Hits 733 733
- Misses 5121 5122 +1
Partials 948 948
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## feature/overlay-tool #826 +/- ##
========================================================
- Coverage 10.77% 10.77% -0.01%
========================================================
Files 210 210
Lines 6802 6803 +1
Branches 1075 1075
========================================================
Hits 733 733
- Misses 5121 5122 +1
Partials 948 948
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our
viewportpixel spacings can be null, which results in a0width/height for thelayerCanvas, which causes an exception.We can either bail out early, or assume a
1:1pixelSpacing in this situation