fix(SegRendering): preserve canvas transform matrix after seg render #1550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously after rendering the segmentation cornerstone was always transforming the canvas to follow the identity matrix, but in cases where we had an overlay using a different transformation matrix, it old undesirably affect the original overlay.
Codecov Report
@@ Coverage Diff @@
## master #1550 +/- ##
==========================================
+ Coverage 23.30% 23.86% +0.55%
==========================================
Files 287 287
Lines 10138 10141 +3
Branches 2082 2082
==========================================
+ Hits 2363 2420 +57
+ Misses 6625 6575 -50
+ Partials 1150 1146 -4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
LGTM 🏅 |
|
🎉 This PR is included in version 6.0.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This PR contains a bug fix.
What is the current behavior? (You can also link to an open issue here)
The current behavior is that my overlay (rendered using the
Overlay Tool) is getting resized and translated once the segmentation is rendered.Note that the text is not even entirely on the screen, also there are two ellipsis that aren't even being shown, they appear on the screenshot below.
Now my overlay is not being resized nor translated and renders on the position where I expected it to be, also the segmentation kept working fine.
Now we can see that the text is well positioned and that the ellipsis are in the right place.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
This PR shoudn't introduce any breaking change.
Other information:
Previously after rendering the segmentation cornerstone was always transforming the canvas to follow the identity matrix, but in cases where we had an overlay using a different transformation matrix, it would undesirably affect the original overlay.
Also did some minor refactorings on the
renderFillfunction of thesrc/eventListeners/internals/renderSegmentationFill.jsfile.