Fix some publish/create SR using dcmjs #1442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wayfarer3130
commented
Oct 22, 2021
| @@ -124,12 +124,14 @@ export default class CobbAngleTool extends BaseAnnotationTool { | |||
| return false; | |||
| } | |||
|
|
|||
| return ( | |||
| const seg1Near = | |||
There was a problem hiding this comment.
This is just some tidying to make it easier to debug.
Codecov Report
@@ Coverage Diff @@
## master #1442 +/- ##
==========================================
+ Coverage 19.76% 20.15% +0.38%
==========================================
Files 286 286
Lines 10082 10097 +15
Branches 2052 2056 +4
==========================================
+ Hits 1993 2035 +42
+ Misses 6878 6851 -27
Partials 1211 1211
Continue to review full report at Codecov.
|
wayfarer3130
commented
Oct 22, 2021
wayfarer3130
commented
Oct 22, 2021
wayfarer3130
commented
Oct 22, 2021
wayfarer3130
commented
Oct 22, 2021
wayfarer3130
commented
Oct 22, 2021
| @@ -26,14 +28,27 @@ const moveHandleNearImagePoint = function( | |||
| ) { | |||
| toolData.active = true; | |||
| state.isToolLocked = true; | |||
| const doneHandler = success => { | |||
There was a problem hiding this comment.
Fire a completed event when the user is done modifying a completed/existing handle, in order to allow updating anything listening. That allows saving the right values into a TID.300 object.
wayfarer3130
force-pushed
the
fix/cobbAngleRestoreFix
branch
from
1833b36 to
1a5afd6
Compare
…th the TID.300 saving changes. Correct notification on tool completion, with values restored correctly when loaded from TID.300 is required for store/save functionality. This is implemented in dcmjs, but the changes are required here. The cobb angle needed to be udpated after restoring, the Rectangle ROI needed the perimeter, and changes needed to publish a completed measurement event.
wayfarer3130
force-pushed
the
fix/cobbAngleRestoreFix
branch
from
1a5afd6 to
8f13fa9
Compare
The existing test only checked negative tests, adding tests for point is near tool.
|
🎉 This PR is included in version 6.0.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bug fix to add support for saving and recreating the cornerstone tools markups, in particular the cobb angle and rectangel roi tools.
This is not a breaking change.
Adding unit tests for cobb angle, and for the rectangeroi