Fix/prefetch beyond bounds #1437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@igoroctaviano - could you take a look? |
Codecov Report
@@ Coverage Diff @@
## master #1437 +/- ##
==========================================
- Coverage 19.87% 19.85% -0.02%
==========================================
Files 285 285
Lines 10040 10036 -4
Branches 2045 2045
==========================================
- Hits 1995 1993 -2
+ Misses 6845 6843 -2
Partials 1200 1200
Continue to review full report at Codecov.
|
wayfarer3130
force-pushed
the
fix/prefetchBeyondBounds
branch
from
217bf6a to
fb91918
Compare
Change the prefetch nearest range to always return valid indices
wayfarer3130
force-pushed
the
fix/prefetchBeyondBounds
branch
from
fb91918 to
45bc894
Compare
|
@igoroctaviano - could you take a look. The defect is that the stack prefetch generated an undefined URL, which was then attempted to be fetched. The fix is in stackPrefetch (the rest of the changes are cumulative), and just sets it up to avoid hitting an undefined URL. |
|
🎉 This PR is included in version 6.0.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fix for prefetching an undefined imageId
Current behaviour:
On prefetching a stack, when the LAST image is displayed first, the prefetch tries to fetch an undefined imageId.
This is caused by the nearestIndex behaviour, which returns -1 for nearest when the requested item is beyond the bounds.
New Behaviour:
The response of nearestIndex was changed to always return valid indices, in specific
low: index size-1
high: 0 for the nearest item, so that the bounds are valid.
Also, the implementation performance is quite a bit better as it doesn't involve creating a list of size n just to determine the bounds location, making the new implementation O(n) rather than O(n log n) as it was previously (the log n factor was caused by inserting into the array).
The PR currently has the code for the overlay fix in it, which should be merged before this one is merged.