Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(netlify-example/brush/index.html): Fixes BrushTool example #1377

Merged
merged 2 commits into from
Jul 30, 2021

Conversation

mikehazell
Copy link
Contributor

@mikehazell mikehazell commented Apr 26, 2021

Fixes a typo which throws an error in the BrushTool example

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Docs example - bug fix

To reproduce:

  1. Go to https://cornerstone-tools.netlify.app/netlify-example/brush/
  2. Inspecting the console will show this error
Uncaught ReferenceError: configuration is not defined
	at (index):542
  1. The Active and Inactive alpha sliders have no effect.
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No

@codecov
Copy link

codecov bot commented Apr 26, 2021

Codecov Report

Merging #1377 (c4248d3) into master (291b8e9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1377   +/-   ##
=======================================
  Coverage   18.93%   18.93%           
=======================================
  Files         286      286           
  Lines        8684     8684           
  Branches     1486     1486           
=======================================
  Hits         1644     1644           
  Misses       5827     5827           
  Partials     1213     1213           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94b7283...c4248d3. Read the comment docs.

@swederik swederik merged commit 95e05ad into cornerstonejs:master Jul 30, 2021
@dannyrb
Copy link
Member

dannyrb commented Jul 30, 2021

🎉 This PR is included in version 5.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants