fix: modifying context of canvas for rendering one tool affects rendering other tools

[codepage949]

fixes #1311

• Please check if the PR fulfills these requirements

• The commit message follows our guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

• What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

fixes bug

• What is the current behavior? (You can also link to an open issue here)

• What is the new behavior (if this is a feature change)?

• Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

no

• Other information:

[codecov]

Codecov Report

Merging #1315 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1315      +/-   ##
==========================================
- Coverage   19.01%   19.00%   -0.01%     
==========================================
  Files         286      286              
  Lines        8652     8655       +3     
  Branches     1479     1479              
==========================================
  Hits         1645     1645              
- Misses       5801     5804       +3     
  Partials     1206     1206              

Impacted Files	Coverage Δ
...c/eventDispatchers/imageRenderedEventDispatcher.js	20.00% <0.00%> (-3.53%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79660e9...9827865. Read the comment docs.

[codepage949]

@dannyrb

if you checked this pr and had some problem, please let me know what the problem is.

i think this bug is critical so i hope to fix as soon as possible.

[dannyrb]

This looks straightforward. Is there a specific tool you're having issues with? Most should be independently using save/restore to prevent this issue.

I can see where this protects from 3rd party tools and any other tools that don't save/restore.

[codepage949]

@dannyrb

below link describes the issue in more detail.

#1311 (comment)

[dannyrb]

Thanks for taking the time to troubleshoot and PR this. As well as @mentioning me. I know I can be a bit hard to get a hold of these days.

I think your solution makes sense, and I can't see how it could hurt. If anything, it should reduce the number of situations in which tools need to use this pattern themselves. I think the draw API wraps itself with this logic already?

Anywhoo. If this doesn't resolve your issues, or if you notice any odd side-effects, please ping me.

[dannyrb]

🎉 This PR is included in version 4.22.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀