Ensure AngleTool and ArrowAnnotateTool fire MEASUREMENT_COMPLETED event #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1204 +/- ##
==========================================
- Coverage 18.73% 18.72% -0.02%
==========================================
Files 286 286
Lines 8571 8576 +5
Branches 1457 1457
==========================================
Hits 1606 1606
- Misses 5774 5779 +5
Partials 1191 1191
Continue to review full report at Codecov.
|
|
@ladeirarodolfo, you can |
dannyrb
reviewed
Apr 1, 2020
| @@ -336,6 +336,18 @@ export default class AngleTool extends BaseAnnotationTool { | |||
| } | |||
|
|
|||
| this.preventNewMeasurement = false; | |||
| external.cornerstone.updateImage(element); | |||
There was a problem hiding this comment.
Why the addition of updateImage? Were you noticing a stale render?
3 tasks
|
🎉 This PR is included in version 4.14.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
ArrowAnnotate and Angle to fire MEASUREMENT_COMPLETED event
What is the current behavior? (You can also link to an open issue here)
ArrowAnnotate and Angle not firing MEASUREMENT_COMPLETED event
What is the new behavior (if this is a feature change)?
ArrowAnnotate and Angle do fire MEASUREMENT_COMPLETED event
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
no breaking change
Other information: