Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: force bitmap cache invalidation #1029

Merged

Conversation

dannyrb
Copy link
Member

@dannyrb dannyrb commented Jul 25, 2019

Mechanism required to force bitmap cache to regenerate. Without it, some scenarios exist where brush data in render loop updates for first instance of an imageId, but fails for all subsequent.

@codecov
Copy link

codecov bot commented Jul 25, 2019

Codecov Report

Merging #1029 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1029      +/-   ##
==========================================
- Coverage   13.69%   13.68%   -0.02%     
==========================================
  Files         223      223              
  Lines        7404     7411       +7     
  Branches     1199     1200       +1     
==========================================
  Hits         1014     1014              
- Misses       5386     5392       +6     
- Partials     1004     1005       +1
Impacted Files Coverage Δ
...eventListeners/onImageRenderedBrushEventHandler.js 0% <0%> (ø) ⬆️
src/store/modules/brushModule.js 6.75% <0%> (-0.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dabef0b...67cc7d0. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jul 25, 2019

Codecov Report

Merging #1029 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1029      +/-   ##
==========================================
- Coverage   13.69%   13.68%   -0.02%     
==========================================
  Files         223      223              
  Lines        7404     7411       +7     
  Branches     1199     1200       +1     
==========================================
  Hits         1014     1014              
- Misses       5386     5392       +6     
- Partials     1004     1005       +1
Impacted Files Coverage Δ
...eventListeners/onImageRenderedBrushEventHandler.js 0% <0%> (ø) ⬆️
src/store/modules/brushModule.js 6.75% <0%> (-0.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dabef0b...67cc7d0. Read the comment docs.

@dannyrb dannyrb merged commit 868f535 into cornerstonejs:master Jul 25, 2019
@dannyrb
Copy link
Member Author

dannyrb commented Jul 25, 2019

🎉 This PR is included in version 3.17.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant