Feature/overlay tool #860

dannyrb · 2019-02-24T22:49:29Z

WIP

… image data See DICOM: http://dicom.nema.org/dicom/2013/output/chtml/part03/sect_C.9.html re #780

…to chore/scoped-packages

… releases

Chore/scoped packages

Change workflow priority

filtering is regex

Fix bash syntax error

invoke script w/ bash

Playing w/ bash syntax in circleCI's environment

Chore/scoped packages

…ster

Make sure we're not stealing a version number that can be used for master

Better RegExp to set version

Tidying up comments and formatting

Try using an alternative package version

Feature/overlay tool

fix overlay tool

Fix build error

Fix prettier build error

Protect against `null` viewport pixelSpacing

codecov · 2019-02-24T22:49:58Z

Codecov Report

Merging #860 into master will increase coverage by 8.08%.
The diff coverage is 42.15%.

@@            Coverage Diff             @@
##           master     #860      +/-   ##
==========================================
+ Coverage   10.77%   18.86%   +8.08%     
==========================================
  Files         210      284      +74     
  Lines        6803     8498    +1695     
  Branches     1075     1446     +371     
==========================================
+ Hits          733     1603     +870     
- Misses       5122     5715     +593     
- Partials      948     1180     +232

Impacted Files	Coverage Δ
src/importInternal.js	`0% <ø> (ø)`
src/eventDispatchers/newImageEventDispatcher.js	`20% <ø> (+20%)`	⬆️
src/drawing/resetCanvasContextTransform.js	`0% <ø> (ø)`	⬆️
src/eventDispatchers/touchToolEventDispatcher.js	`100% <ø> (ø)`	⬆️
src/events.js	`100% <ø> (ø)`	⬆️
src/lib.js	`100% <ø> (+100%)`	⬆️
src/drawing/drawEllipse.js	`0% <0%> (ø)`	⬆️
src/drawing/drawRect.js	`0% <0%> (ø)`	⬆️
...ispatchers/mouseEventHandlers/mouseDownActivate.js	`0% <0%> (ø)`	⬆️
src/drawing/transformCanvasContext.js	`0% <0%> (ø)`	⬆️
... and 256 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c7581d...7ae3a8d. Read the comment docs.

dannyrb · 2019-02-24T22:53:01Z

Resolve scoped package conflict
Add proper commit messages (squash?)
Unit tests?

dannyrb · 2020-01-28T11:51:42Z

🎉 This PR is included in version 4.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

dannyrb added 30 commits February 6, 2019 23:49

feat(OverlayTool): Support for rendering overlay layers on top of the…

8a58d41

… image data See DICOM: http://dicom.nema.org/dicom/2013/output/chtml/part03/sect_C.9.html re #780

Add OverlayTool exports

bfbe4f2

Add overlay tool to examples

51af0d3

Make sure enabledElement is defined

e9c6cff

Capitalize data-tool; better tool toggling

8a295db

lowercase first letter 👍

a97781a

Use @cornerstonejs org scope

4ab5f1e

Merge branch 'master' of github.com:cornerstonejs/cornerstoneTools in…

2c189d1

…to chore/scoped-packages

dry run; finding tag and publishing feature/hotfix branches as tagged…

0f60830

… releases

Merge branch 'master' into feature/overlay-tool

82d4aa2

Merge pull request #811 from dannyrb/chore/scoped-packages

ea40874

Chore/scoped packages

Change workflow priority

191e83e

Merge pull request #812 from dannyrb/chore/scoped-packages

a0a605f

Change workflow priority

filtering is regex

0ba698a

Merge pull request #813 from dannyrb/chore/scoped-packages

e83c3a9

filtering is regex

Fix bash syntax error

709a51b

Merge pull request #814 from dannyrb/chore/scoped-packages

cd93cc0

Fix bash syntax error

invoke script w/ bash

f2ea5e4

Merge pull request #815 from dannyrb/chore/scoped-packages

3fa81eb

invoke script w/ bash

Playing w/ bash syntax in circleCI's environment

91a5fd2

Merge pull request #816 from dannyrb/chore/scoped-packages

b8bdcc2

Playing w/ bash syntax in circleCI's environment

Public scoped packages

6d644e6

Publish a tagged package

031b09d

Merge pull request #817 from dannyrb/chore/scoped-packages

7b43e30

Chore/scoped packages

Make sure we're not stealing a version number that can be used for ma…

b9900be

…ster

Merge pull request #818 from dannyrb/chore/scoped-packages

e379604

Make sure we're not stealing a version number that can be used for master

Better RegExp to set version

1acd2b0

Merge pull request #819 from dannyrb/chore/scoped-packages

8030741

Better RegExp to set version

Tidying up comments and formatting

b9fc34d

Merge pull request #820 from dannyrb/chore/scoped-packages

967fa41

Tidying up comments and formatting

dannyrb and others added 12 commits February 8, 2019 12:31

Try using an alternative package version

993c9f6

Merge pull request #821 from dannyrb/chore/scoped-packages

1840779

Try using an alternative package version

Merge pull request #809 from dannyrb/feature/overlay-tool

9adff5d

Feature/overlay tool

Update OverlayTool.js

b9ec2d6

Merge pull request #823 from kofifus/patch-11

bf67fdf

fix overlay tool

Update OverlayTool.js

0379877

Merge pull request #824 from kofifus/patch-12

3aaaf13

Fix build error

Fix prettier build error

bb52360

Merge pull request #825 from dannyrb/feature/overlay-tool

6c663a0

Fix prettier build error

Protect against null viewport pixelSpacing

68fa91a

Merge branch 'feature/overlay-tool' into feature/overlay-tool

f0d634e

Merge pull request #826 from dannyrb/feature/overlay-tool

6c7581d

Protect against `null` viewport pixelSpacing

dannyrb mentioned this pull request Jul 3, 2019

Overlay Data unable to display! cornerstonejs/cornerstone#386

Closed

dannyrb added the Awaiting Contributor Response label Jul 11, 2019

dannyrb self-assigned this Jul 11, 2019

swederik added 4 commits January 28, 2020 10:15

Merge branch 'master' into feature/overlay-tool

a1ec61a

Remove unnecessary changes

a5d93bf

Fix unnecessary changes

316e80a

Fixes for rendering overlays

7ae3a8d

swederik merged commit 4eef070 into master Jan 28, 2020

dannyrb added the released label Jan 28, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/overlay tool #860

Feature/overlay tool #860

dannyrb commented Feb 24, 2019

codecov bot commented Feb 24, 2019 •

edited

Loading

dannyrb commented Feb 24, 2019

dannyrb commented Jan 28, 2020

Feature/overlay tool #860

Feature/overlay tool #860

Conversation

dannyrb commented Feb 24, 2019

WIP

codecov bot commented Feb 24, 2019 • edited Loading

Codecov Report

dannyrb commented Feb 24, 2019

dannyrb commented Jan 28, 2020

codecov bot commented Feb 24, 2019 •

edited

Loading