freehand tool doesn't fire MEASUREMENT_MODIFIED event

[Zaid-Safadi]

Prerequisites

• Are you running the latest version?
  Using v2.4.0
• Are you reporting to the correct repository?
• Did you perform a cursory search?

For more information, see the CONTRIBUTING guide.

Description

The freehand tool doesn't fire the cornerstonetoolsmeasurementmodified event as the other measurement tools

Not sure if this issue is fixed in vNext.

Steps to Reproduce

1. Register to the event element.addEventListener("cornerstonetoolsmeasurementmodified", onModified);
2. draw a freehand
3. Event is not being called.

Expected behavior:
The event "cornerstonetoolsmeasurementmodified" be fired and the handler is called.

Actual behavior:
Event is not fired.

[Zaid-Safadi]

If possible to update this in v2.4.0 I'll submit a PR and if someone can confirmed it exists in vNext I'll update that too.

This can be fixed by firing the event in the addPoint and endDrawing methods:

/**
* Adds a point on mouse click in polygon mode.
*
* @param {Object} eventData - data object associated with an event.
*/
function addPoint (eventData) {
...
// Increment the current handle value
  config.currentHandle += 1;
  fireModified(eventData.element, data);
...
...
}

/**
* Ends the active drawing loop and completes the polygon.
*
* @param {Object} eventData - data object associated with an event.
* @param {Object} handleNearby - the handle nearest to the mouse cursor.
*/
function endDrawing (eventData, handleNearby) {
  ...
  data.canComplete = false;

  fireModified(eventData.element, data);

  external.cornerstone.updateImage(eventData.element);
}

function fireModified (element, data) {
  const eventType = EVENTS.MEASUREMENT_MODIFIED;
  const modifiedEventData = {
    toolType,
    element,
    measurementData: data
  };

  triggerEvent(element, eventType, modifiedEventData);
}

[Zaid-Safadi]

This is fixed for v2 in branch v2.4.x.
I will leave it open to apply the fix for v3

[JamesAPetts]

Hey @Zaid-Safadi , if I get time tomorrow I can do this for v3/master :).

[Zaid-Safadi]

That would be really nice @JamesAPetts ! please let me know know if there is anything I can help with. Thank you

[dannyrb]

Fixed in 3.10