-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Divergence on toolType/toolName naming convention #1216
fix: Divergence on toolType/toolName naming convention #1216
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1216 +/- ##
==========================================
- Coverage 18.71% 18.71% -0.01%
==========================================
Files 286 286
Lines 8582 8583 +1
Branches 1459 1459
==========================================
Hits 1606 1606
- Misses 5783 5784 +1
Partials 1193 1193
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming the demo plays nicely, it builds, and tests pass, then this should help clarify things quite a bit! I did call out when renaming that may not be correct that we should double check.
🎉 This PR is included in version 4.15.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR resolved #991 |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
toolType
/toolName
being added to event data.toolName
as being the new attribute to be used.toolType
attribute.What is the current behavior? (You can also link to an open issue here)
toolType
attribute and others withtoolName
attribute.What is the new behavior (if this is a feature change)?
toolType
attribute is removed, all the event data are including bothtoolType
andtoolName
attributes.Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
toolType
attribute.toolType
is removed for good.Other information:
toolType
naming is now going to be used to categorize types of tools (e.g.general
,annotation
,stack
,segmentation
, etc.)