Skip to content

Commit

Permalink
fix: Fix RotateTool on mobile devices (#1385)
Browse files Browse the repository at this point in the history
* Fix - RotateTool for mobile devices

* Refactor fix RotateTool

* Feature - testUnit for RotateTool on mobile devices

* Refactor validation on RotateTool

* Change validation structure

Co-authored-by: Luis Alberto Martinez <[email protected]>
  • Loading branch information
Zckr07 and Luis Alberto Martinez authored Jul 30, 2021
1 parent c9837ca commit cdf23b5
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 1 deletion.
5 changes: 4 additions & 1 deletion src/tools/RotateTool.js
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,10 @@ export default class RotateTool extends BaseTool {
function defaultStrategy(evt) {
const { roundAngles, rotateScale } = this.configuration;
const { element, viewport, startPoints, currentPoints } = evt.detail;
const initialRotation = viewport.initialRotation;

const initialRotation = viewport.initialRotation
? viewport.initialRotation
: viewport.rotation;

// Calculate the center of the image
const rect = element.getBoundingClientRect(element);
Expand Down
19 changes: 19 additions & 0 deletions src/tools/RotateTool.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,15 @@ const mockEvt = {
},
};

const forMobileMockEvt = {
detail: {
viewport: {
rotation: 50,
initialRotation: undefined,
},
},
};

describe('RotateTool.js', () => {
describe('default values', () => {
it('has a default name of "Rotate"', () => {
Expand Down Expand Up @@ -48,5 +57,15 @@ describe('RotateTool.js', () => {
instantiatedTool.dragCallback(mockEvt);
expect(external.cornerstone.setViewport).toHaveBeenCalled();
});

it('can be created on mobile device', () => {
const instantiatedTool = new RotateTool();

instantiatedTool.applyActiveStrategy = jest.fn();
external.cornerstone.setViewport = jest.fn();

instantiatedTool.dragCallback(forMobileMockEvt);
expect(external.cornerstone.setViewport).toHaveBeenCalled();
});
});
});

0 comments on commit cdf23b5

Please sign in to comment.