fix(suv display): fix scaling of non-SUV PT images #536
Conversation
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
| @@ -1,8 +1,6 @@ | |||
| function getModalityUnit(modality: string, isPreScaled: boolean): string { | |||
| if (modality === 'CT') { | |||
| return 'HU'; | |||
| } else if (modality === 'PT' && isPreScaled === true) { | |||
There was a problem hiding this comment.
Why we are removing this unit here?
There was a problem hiding this comment.
Because a PT image can be in many different units, e.g. counts or Bq/ml (see the full list here: https://dicom.nema.org/medical/dicom/current/output/chtml/part03/sect_C.8.9.html#sect_C.8.9.1.1.3).
If we want to display the correct unit, we would have to know the (0054,1001) tag in addition to knowing whether SUV rescaling has been applied. I thought it's better to not show a unit than the wrong one.
There was a problem hiding this comment.
Can we get the metadata and check if suvbw is there in scalingModule, and return 'SUV' to be able to show SUV like before?
| @@ -1021,8 +1023,15 @@ class CircleROITool extends AnnotationTool { | |||
| stdDev /= count; | |||
| stdDev = Math.sqrt(stdDev); | |||
|
|
|||
| const { suvbw } = | |||
There was a problem hiding this comment.
we don't need to do this metadata query on each cachedStats calculation since it doesn't change with annotation data change, it can be done outside, in the render loop, just before _getTextLines calls
There was a problem hiding this comment.
moved the metadata query
|
Some tests are currently failing. I assume it's because of the metadata query, but I'm not sure how to fix it. |
|
can you follow this please https://www.cornerstonejs.org/docs/contribute/update-api |
|
seems like tools' tests are failing, maybe look here to how to run tests locally https://www.cornerstonejs.org/docs/contribute/tests |
It seems like in some tests Do you think calling If I catch the undefined in |
|
Added a check for |
|
Hmmm, this will break our volume viewports I guess, since they don't necessarily have referenceImageId, right now they can show suv
I guess the correct logic can be created inside AnnotationTool base class to check if it is a volume or stack. If volume it checks if scaling is presented in the volume (https://github.com/cornerstonejs/cornerstone3D-beta/blob/578830013cb7b9474166dfe1f469f7908b39aabe/packages/core/src/cache/classes/ImageVolume.ts#L37-L46), and for stack it looks at scaling module or seems like we have StackViewport.scaling as well that you can check. |
|
Added |
sedghi
changed the title
|
Thank you for your help and your great work on this project in general! 🎉 |
Currently PT images that are not in SUV are not rescaled at all. This is problematic because PT images can be in units of e.g. counts or Bq/ml, so it's important that the rescaling is applied in those cases.