Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jpeg2000 bug for blurry pixels #18

Closed
sedghi opened this issue Dec 6, 2022 · 1 comment
Closed

jpeg2000 bug for blurry pixels #18

sedghi opened this issue Dec 6, 2022 · 1 comment

Comments

@sedghi
Copy link
Member

sedghi commented Dec 6, 2022

Apparently switching j2k decoder to wasm has introduced a pixelated/blury bug for some images.

Reported here:

Data by community can be found here

Based on my investigation the bug has happened on this commit for CSWIL (the commit for changing to wasm codecs)

e38c066 (tag: v4.0.0) feat(codecs, loadImage): Switch to WASM Codecs, use image load into distinct queues for retrievals and decoding (#39

Steps Taken

Using the dev containers for our codec repo, first I tried to use Chris Hafey's openjpeg codec (since it is more up to date than ours here).

Updating the git submodule was very tricky, it didn't like changing the external git repo, I had to force remove the remote and add the new one.

After the build, and copy pasting the new wasm codecs (generated by build) and putting it inside the CSWIL node_modules for the openjpeg folder, and rebuilding the CSWIL and running example, it didn't work

However, seems like Chris's demo which uses raw dicom pixel data works with the shared data by community.
To extract the pixel data drag and drop data here and check the Frames and download the binary and drag and drop into Chris's demo here

So my assumption is his build of the openjpeg is different than ours and for him it works and not for us.

CC @swederik @heyflynn @kunjesh1 @lambacini

@sedghi
Copy link
Member Author

sedghi commented Dec 6, 2022

After above this I noticed Chris's src folder had some changes compared to us.

Adapting the changes from Chris, I'm not encountring the following error
image

I will investigate later

Try to see what does

  c.width = frameInfo.width;
    c.height = frameInfo.height;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants