You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Based on my investigation the bug has happened on this commit for CSWIL (the commit for changing to wasm codecs)
e38c066 (tag: v4.0.0) feat(codecs, loadImage): Switch to WASM Codecs, use image load into distinct queues for retrievals and decoding (#39
Steps Taken
Using the dev containers for our codec repo, first I tried to use Chris Hafey's openjpeg codec (since it is more up to date than ours here).
Updating the git submodule was very tricky, it didn't like changing the external git repo, I had to force remove the remote and add the new one.
After the build, and copy pasting the new wasm codecs (generated by build) and putting it inside the CSWIL node_modules for the openjpeg folder, and rebuilding the CSWIL and running example, it didn't work
However, seems like Chris's demo which uses raw dicom pixel data works with the shared data by community.
To extract the pixel data drag and drop data here and check the Frames and download the binary and drag and drop into Chris's demo here
So my assumption is his build of the openjpeg is different than ours and for him it works and not for us.
Apparently switching j2k decoder to wasm has introduced a pixelated/blury bug for some images.
Reported here:
Data by community can be found here
Based on my investigation the bug has happened on this commit for CSWIL (the commit for changing to wasm codecs)
Steps Taken
Using the dev containers for our codec repo, first I tried to use Chris Hafey's openjpeg codec (since it is more up to date than ours here).
Updating the git submodule was very tricky, it didn't like changing the external git repo, I had to force remove the
remote
and add the new one.After the build, and copy pasting the new wasm codecs (generated by build) and putting it inside the CSWIL node_modules for the openjpeg folder, and rebuilding the CSWIL and running example, it didn't work
However, seems like Chris's demo which uses raw dicom pixel data works with the shared data by community.
To extract the pixel data drag and drop data here and check the
Frames
and download the binary and drag and drop into Chris's demo hereSo my assumption is his build of the openjpeg is different than ours and for him it works and not for us.
CC @swederik @heyflynn @kunjesh1 @lambacini
The text was updated successfully, but these errors were encountered: