Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating FA24 Contributors in the README File #227

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

shah-esha
Copy link
Collaborator

@shah-esha shah-esha commented Oct 7, 2024

Added my name and role to FA24 contributor list

This is my first pull request, where I added my name to the list of CGO FA24 contributors after pulling Frank's changes, where he added other members. I wrote my name specifically in the "developer" section.

@CLAassistant
Copy link

CLAassistant commented Oct 7, 2024

CLA assistant check
All committers have signed the CLA.

@dti-github-bot
Copy link
Member

dti-github-bot commented Oct 7, 2024

[diff-counting] Significant lines: 1.

@3TTemi
Copy link
Contributor

3TTemi commented Oct 8, 2024

Going to reiterate what I commented on Franks PR:

Looks great! This is an good PR to start getting familiar with Git and our developer workflow. For future pull requests, I recommend following the default pull request template, which includes sections like "Summary," "Remaining TODOs," "Test Plan," "Notes," "Blockers," and "Breaking Changes." While this PR doens't apply to most of these categories, some sections are required. You can simply just put down "Not Applicable" where relevant and jsut make sure to fill in the summary in the summary. This keeps our PRs consistent and easy to read.

BrianLa0616
BrianLa0616 previously approved these changes Nov 9, 2024
Copy link
Contributor

@BrianLa0616 BrianLa0616 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Make sure to always pull main before doing the final merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants