Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

force override any defaults #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

force override any defaults #5

wants to merge 2 commits into from

Conversation

gko
Copy link

@gko gko commented May 22, 2019

First of all thank you for the theme. ❤️

I noticed that some colors are not applied when you use hi link(the defaults are forced):
image

So I replaced all hi link with hi! link to force the usage of linked rules:
image

@cormacrelf
Copy link
Owner

cormacrelf commented May 24, 2019

That’s what hi clear does, isn’t it? Not sure what went wrong for you.

@gko
Copy link
Author

gko commented May 25, 2019

@cormacrelf yes it should. But I have a problem with «SignColumn». It seems to not be affected by hi clear. It works however if I add another hi clear SignColumn. Weird.

@cormacrelf
Copy link
Owner

@gko It should... and it does. Can you reproduce with every other vim setting at its default?

@gko
Copy link
Author

gko commented May 25, 2019

Yes I can:
NVIM v0.3.4
Os: MacOS 10.14.5
Terminal: Both MacOs terminal and iTerm

~/.config/nvim/init.vim:

set number
set signcolumn=yes
color github

The only file in ~/.config/nvim/ folder:
colors/github.vim

Result:
image

@gko
Copy link
Author

gko commented May 25, 2019

vim 8.1.1150

~/.vimrc:

syntax on
set t_Co=256
set number
set signcolumn=yes
color github

Result:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants