This is supposed to fix broken corner in case it is very close to an edge (for .down direction only) #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot exactly at that edge yet
|
Please, don't accept it yet. Found some artifacts, will try to fix them. |
…d behind the edge (only applicable for .up position) + added test buttons into the demo app
|
Fixed some artifacts and covered the case when target view is behind the corner. The change is only applicable for |
vitalii-tym
changed the title
vitalii-tym
changed the title
|
I'm sorry to be late. Good Job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The corner used to be corrected in case it its point is exactly at an edge, but in case the corner is not at the edge there was some visual cut-out.
Not sure, but probably it is also mentioned in the issue #33
How it used to be:
After fix:
