-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added GitVersion to the CI. #237
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
Code Climate has analyzed commit d47ebd5 and detected 0 issues on this pull request. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
We might run into an issue at some point locally with running Ubuntu 20.04 remotely (local image is still 18.04), but there's no 20.04 available at https://hub.docker.com/r/nektos/act-environments-ubuntu/tags?page=1&ordering=last_updated so I think the change is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to make changes in the NuGet packaging work that'll remove the following:
<VersionPrefix>1.0.0</VersionPrefix>
<VersionSuffix>dev-$([System.DateTime]::Now.ToString("yyyyMMddTHHmm"))</VersionSuffix>
That way, it'll just use what is provided via GitVersion. This makes this PR required to be able to use NuGet packaging.
Added GitVersion to the CI to automatically determine the version number for us. More details in #228.
I also changed the CI scripts to use Ubuntu 20.04 instead of latest.
Closes #228.
Note: This will have a couple commits as I fix the CI.