Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added GitVersion to the CI. #237

Merged
merged 8 commits into from
Feb 18, 2021
Merged

Conversation

mrbiggred
Copy link
Contributor

@mrbiggred mrbiggred commented Feb 15, 2021

Added GitVersion to the CI to automatically determine the version number for us. More details in #228.

I also changed the CI scripts to use Ubuntu 20.04 instead of latest.

Closes #228.

Note: This will have a couple commits as I fix the CI.

@mrbiggred mrbiggred self-assigned this Feb 15, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Feb 15, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@mrbiggred
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Feb 15, 2021
@mrbiggred mrbiggred marked this pull request as ready for review February 16, 2021 00:03
@mrbiggred mrbiggred marked this pull request as draft February 16, 2021 00:04
@mrbiggred mrbiggred marked this pull request as ready for review February 16, 2021 17:40
@mrbiggred mrbiggred requested a review from dfar-io February 16, 2021 17:40
@codeclimate
Copy link

codeclimate bot commented Feb 16, 2021

Code Climate has analyzed commit d47ebd5 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

@dfar-io dfar-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

We might run into an issue at some point locally with running Ubuntu 20.04 remotely (local image is still 18.04), but there's no 20.04 available at https://hub.docker.com/r/nektos/act-environments-ubuntu/tags?page=1&ordering=last_updated so I think the change is fine.

Copy link
Contributor

@dfar-io dfar-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to make changes in the NuGet packaging work that'll remove the following:

<VersionPrefix>1.0.0</VersionPrefix>
<VersionSuffix>dev-$([System.DateTime]::Now.ToString("yyyyMMddTHHmm"))</VersionSuffix>

That way, it'll just use what is provided via GitVersion. This makes this PR required to be able to use NuGet packaging.

@mrbiggred mrbiggred merged commit 2aeaee9 into main Feb 18, 2021
@mrbiggred mrbiggred deleted the feature-228-determine-version-number branch February 18, 2021 17:20
@github-actions github-actions bot locked and limited conversation to collaborators Feb 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto-magically calculate version number
2 participants