Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable CartStockAvailability constraint in revise action #2461

Merged
merged 3 commits into from
Dec 9, 2023

Conversation

solverat
Copy link
Contributor

@solverat solverat commented Dec 4, 2023

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets #2460

This PR is a Proposal to fix the stock check within the revise action.

@solverat
Copy link
Contributor Author

solverat commented Dec 4, 2023

Maybe setting the coreshop.form.type.order.payment.validation_groups to coreshop_revise is better than declaring it in the controller? This Form only shows up in the revise process, so no conflicts here.

@solverat
Copy link
Contributor Author

solverat commented Dec 4, 2023

Another fix in my PR: The CoreShop\Component\Order\Model\Order not necessarily knows about the revise. Coping this constraint to CoreShop/Bundle/CoreBundle/Resources/config/validation/Order.yml could fix this "dependency".

@dpfaffenbauer
Copy link
Member

Another fix in my PR: The CoreShop\Component\Order\Model\Order not necessarily knows about the revise. Coping this constraint CoreShop/Bundle/CoreBundle/Resources/config/validation/Order.yml could fix this "dependency".

You mean the validation config for Order?

@solverat
Copy link
Contributor Author

solverat commented Dec 4, 2023

Yes!

@dpfaffenbauer
Copy link
Member

@solverat For me the PR seems fine. You declared it as proposal, is anything missing?

@solverat
Copy link
Contributor Author

solverat commented Dec 6, 2023

@dpfaffenbauer Now it's done, if you're okay with it. I've adopted following change:

Maybe setting the coreshop.form.type.order.payment.validation_groups to coreshop_revise is better than declaring it in the controller? This Form only shows up in the revise process, so no conflicts here.

@dpfaffenbauer dpfaffenbauer merged commit ef1d96d into coreshop:3.1 Dec 9, 2023
417 checks passed
@solverat solverat deleted the revise_fix branch December 12, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants