-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ClassDefinitionPatchBundle] introduce new Bundle to allow patching Pimcore Class Definitions #2279
[ClassDefinitionPatchBundle] introduce new Bundle to allow patching Pimcore Class Definitions #2279
Conversation
…imcore Class Definitions
…imcore Class Definitions
…imcore Class Definitions
…imcore Class Definitions
…imcore Class Definitions
|
||
private function makePlusLinesGreen(string $string): string | ||
{ | ||
return Strings::replace($string, self::PLUS_START_REGEX, '<fg=green>$1</fg=green>'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason you're using the Nette tools here, instead of the Symfony string component?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I copied that part from somewhere else. I dind't wanna include a package just for this. I can check if Symfony String also solves this. Makes one less dependency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jdreesen works with Symfony String, thanks for the hint 💪
Co-authored-by: Jacob Dreesen <[email protected]>
…imcore Class Definitions
…imcore Class Definitions
This feature allows to patch class definitions and preview the patches for Pimcore Class Definitions. Use Case is mainly for other Extensions that need new fields or changes on Class Definitions.
Example: