Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix addressAccessType check and improve view #1544

Merged
merged 2 commits into from
Dec 29, 2020
Merged

fix addressAccessType check and improve view #1544

merged 2 commits into from
Dec 29, 2020

Conversation

solverat
Copy link
Contributor

Q A
Bug fix? yes
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets --

Fixes

  • getAddressAccessType can be null or an empty string (pimcore at its best...)
  • Add address type badge to address overview card for better identification (if defined)
  • Add address type headline on editing for better identification (if defined)

@dpfaffenbauer dpfaffenbauer added this to the 2.2.6 milestone Dec 16, 2020
@dpfaffenbauer dpfaffenbauer self-requested a review December 16, 2020 13:05
@dpfaffenbauer dpfaffenbauer modified the milestones: 2.2.6, 2.2.7 Dec 18, 2020
@dpfaffenbauer dpfaffenbauer merged commit e3aec5f into coreshop:2.2 Dec 29, 2020
@solverat solverat deleted the address_fixes branch January 24, 2021 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpfaffenbauer dpfaffenbauer dpfaffenbauer approved these changes

Assignees

@solverat solverat

Labels
bug enhancement
Projects
None yet
Milestone
2.2.7
Development

Successfully merging this pull request may close these issues.
2 participants
@solverat @dpfaffenbauer