Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: run renovate only once per week to reduce noise #276

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

theseion
Copy link
Collaborator

No description provided.

@theseion theseion requested a review from fzipi March 16, 2024 07:37
@dune73
Copy link
Member

dune73 commented Mar 18, 2024

Does the renovate bot actions also include security relevant findings? If yes, I'd rather have the noise than the delay.

@theseion
Copy link
Collaborator Author

Potentially, yes. But it really doesn't help to have the noise. Even if there's a relevant issue, we would still have to cut a release etc. IMO, there's no difference whether this occurs a week earlier or later, especially, since we're talking about a test tool here, not a public web server. Remember, that it's pretty much me and @fzipi carrying the weight and we also have other things to do.

@dune73
Copy link
Member

dune73 commented Mar 18, 2024

Agreed. It makes sense in such a situation.

@fzipi fzipi merged commit 8175429 into coreruleset:main Mar 21, 2024
3 checks passed
@theseion theseion deleted the reduce-renovate-noise branch March 22, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants