Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

\r processed as literal in double quoted strings #359

Closed
theseion opened this issue Sep 22, 2024 · 3 comments
Closed

\r processed as literal in double quoted strings #359

theseion opened this issue Sep 22, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@theseion
Copy link
Collaborator

goccy/go-yam has only recently added processing of \r in double quoted strings. We need to upgrade goccy/go-yaml but are currently blocked due to the performance impact solved by goccy/go-yaml#438.

@theseion theseion added the bug Something isn't working label Sep 22, 2024
theseion added a commit to theseion/go-ftw that referenced this issue Nov 10, 2024
The new tests specifically test unmarshalling of line feed and carriage
return escape sequences in double qouted strings, as that was an issue
with goccy/go-yaml.

Refs coreruleset#359
@theseion
Copy link
Collaborator Author

Fixed by #375

fzipi added a commit that referenced this issue Nov 18, 2024
The new tests specifically test unmarshalling of line feed and carriage
return escape sequences in double qouted strings, as that was an issue
with goccy/go-yaml.

Refs #359

Co-authored-by: Felipe Zipitría <[email protected]>
@fzipi
Copy link
Member

fzipi commented Dec 18, 2024

Can we close this one?

@theseion
Copy link
Collaborator Author

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants