Service IP addresses should use cidrhost(tectonic_service_cidr, …)

[ggreer]

tectonic_kube_apiserver_service_ip, tectonic_kube_etcd_service_ip, and tectonic_kube_dns_service_ip should all use cidrhost() instead of hard-coded default values.

Currently, the user must change all of those values if they want to use a different service cidr. Also, the frontend must calculate all those values.

[s-urbaniak]

This fall in the bucket "how much logic do we want in the tf templates", but I agree that is a neat idea.

[sym3tri]

Asking users to update these IPs manually is a recipe for frustration. There's no current use-case for needing to override them. This I agree, let's just do it in the templates unless there's a compelling reason not to.

…

On Mon, May 15, 2017 at 06:16 Sergiusz Urbaniak ***@***.***> wrote: This fall in the bucket "how much logic do we want in the tf templates", but I agree that is a neat idea. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#642 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AANr3kkVw4YgTilxznqR08sR54QvAhFdks5r6FA-gaJpZM4NXWDJ> .

[alexsomesan]

This is a cool idea and should not be a complicated change.

@sym3tri The point @ggreer is trying to make is it actually would not require users to change anything in the template. It would just compute them when they are not provided in tfvars (like we do with subnets today). I think that's a neat usability improvement. It would unclutter the tfvars too.

[sym3tri]

I know. I was agreeing with him ;)

…

On Tue, May 16, 2017 at 03:16 Alex Somesan ***@***.***> wrote: This is a cool idea and should not be a complicated change. @sym3tri <https://github.com/sym3tri> The point @ggreer <https://github.com/ggreer> is trying to make is it actually would not require users to change anything in the template. It would just compute them when they are not provided in tfvars (like we do with subnets today). I think that's a neat usability improvement. It would unclutter the tfvars too. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#642 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AANr3lRykwZXx7TafSs3GL7KeagVeUlTks5r6XeagaJpZM4NXWDJ> .

[alexsomesan]

Oh well, I guess I need to pay closer attention :) Sorry for causing confusion.