This repository has been archived by the owner on Feb 5, 2020. It is now read-only.
logging: add link to github repository #143
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chancez
reviewed
Mar 5, 2018
| @@ -13,6 +13,8 @@ There are currently 4 prebuilt Debian based Docker images in the [quay.io/coreos | |||
|
|
|||
| **Note**: there are Alpine based images which are automatically published along side the Debian images, but they cannot be used in conjunction with the systemd input plugin, because Alpine has no `libsystemd` package available. | |||
|
|
|||
| The source of these docker images can be found at [coreos/fluentd-kubernetes-daemonset][github-coreos-fluentd] on Github. | |||
There was a problem hiding this comment.
Can you add a note here to also mention they should use the tectonic_logging branch (sometimes navigating github can lose the branch your own).
There was a problem hiding this comment.
"For source information, use the tectonic_logging branch found at https://github.com/coreos/fluentd-kubernetes-daemonset/tree/tectonic_logging on GitHub."
@chancez will using the branch be a permanent requirement? or will this go pure upstream at some point?
There was a problem hiding this comment.
It won't be upstreamed, these changes are Tectonic specific. We also don't really actively maintain this stuff.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had several customers send in tickets searching for the source of the fluentd images. This PR adds a link to the github repository that contains this info.