scripts: Support overriding lua, use for glibc-all-langpacks #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today in Fedora the `glibc-all-langpacks.posttrans` is implemented in lua, for no good reason. See: https://bugzilla.redhat.com/show_bug.cgi?id=1367585 Since that's stalled out, let's add support for overrides. This is obviously a much bigger step with more long term maintenance implications over our current "ignore scripts" list. But we can't block either. This is needed for unified core work: coreos#729 (We also override `fedora-release-atomichost` but I'll likely submit a patch for that upstream)
|
If we're going to do this, should we do a checksum of the scripts and comparing them before overriding as an extra measure? Is it just those two packages as far as Fedora Atomic Host is concerned? |
|
Yep, it's just those two for FAH. I haven't yet tried workstation or for that matter evaluated all packages. As far as checksums...eh, I suspect we can at least get the glibc maintainers to ping us if they change it. |
|
Alrighty, let's do this! (Random aside: the tests for this PR were run in the new OpenStack environment. For some reason though, the CentOS nodes never finished provisioning. Will have to look at that.) |
|
☀️ Test successful - status-atomicjenkins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today in Fedora the
glibc-all-langpacks.posttransis implementedin lua, for no good reason. See:
https://bugzilla.redhat.com/show_bug.cgi?id=1367585
Since that's stalled out, let's add support for overrides. This
is obviously a much bigger step with more long term maintenance
implications over our current "ignore scripts" list. But we can't
block either.
This is needed for unified core work:
#729
(We also override
fedora-release-atomichostbut I'll likelysubmit a patch for that upstream)