daemon: Add a sanitycheck(/bin/true) before we deploy a tree #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a followup to coreos#888 but more comprehensive; in the layering case, the sanitycheck runs after all the `%posttrans` scripts, so we'll get a consistent error message for the `rm -rf /` test. We also do the sanitycheck for the "pure ostree" case, as well as cases where we didn't actually layer packages (including `ex override remove` as well as simply regenerating an initrd). There's obviously a lot more we could do in a sanitycheck; as I say in the comment it's tempting to consider trying to boot systemd (in a fully volatile config), but for now let's do this. In the end of course the admin has rollback too.
cgwalters
force-pushed
the
deployment-sanity-check
branch
from
a3f177a to
3c7c2e2
Compare
|
Rebased 🏄♂️ |
jlebon
reviewed
Jul 26, 2017
| * and might save someone in the future. The RPMOSTREE_SKIP_SANITYCHECK | ||
| * environment variable is just used by test-basic.sh currently. | ||
| */ | ||
| if (!self->final_revision && !getenv ("RPMOSTREE_SKIP_SANITYCHECK")) |
There was a problem hiding this comment.
Shouldn't we put the getenv check in rpmostree_deployment_sanitycheck() itself?
|
☀️ Test successful - status-atomicjenkins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #888
but more comprehensive; in the layering case, the sanitycheck runs
after all the
%posttransscripts, so we'll get a consistent error messagefor the
rm -rf /test.We also do the sanitycheck for the "pure ostree" case, as well as cases
where we didn't actually layer packages (including
ex override removeaswell as simply regenerating an initrd).
There's obviously a lot more we could do in a sanitycheck; as I say in the
comment it's tempting to consider trying to boot systemd (in a fully volatile
config), but for now let's do this. In the end of course the admin has rollback
too.