Fix experimental notice #688
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow-up to coreos#683. All the experimental commands will be under `rpm-ostree ex`, so we remove the flag and instead print the notice before dispatching the subcommand, where we can print the correct name.
Make `rpm-ostree compose bad-command` and `rpm-ostree ex bad-command` have the same error message formatting.
|
Ah, yep, makes sense to me. What I was trying to say before is basically I think we should take into account the benefits of refactoring - we could have the absolute best command line parsing code in the world and our users probably wouldn't notice the difference. But I definitely agree this patch is better! |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Mar 16, 2017
Make `rpm-ostree compose bad-command` and `rpm-ostree ex bad-command` have the same error message formatting. Closes: #688 Approved by: cgwalters
|
☀️ Test successful - status-atomicjenkins |
|
No, I totally understand effort vs effect. I guess to me this goes with #405: it's part of making rpm-ostree/$newname look and feel tight. Consistency, good error msgs, etc... It seems trivial, but altogether they're the sort of things by which e.g. less technical people might judge an app. But yeah, I agree we also have to strike a balance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #683.
I'm sorry, I couldn't help it! 👞 ✨ :)