tests: Stop using "ostree trivial-httpd" #684
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I built+installed ostree git master with ostreedev/ostree#723 in my dev container, which broke the rpm-ostree tests. Kind of embarrassing that I forgot to check rpm-ostree for usage of `ostree trivial-httpd`. This is another thing that really wants a shared test container. Anyways let's just use Python for this.
cgwalters
force-pushed
the
drop-trivial-httpd
branch
from
abca962 to
1c222ba
Compare
jlebon
reviewed
Mar 16, 2017
| run_temp_webserver() { | ||
| env PYTHONUNBUFFERED=1 setsid python -m SimpleHTTPServer 0 >${test_tmpdir}/httpd-output & | ||
| for x in $(seq 50); do | ||
| sed -e 's,Serving HTTP on 0.0.0.0 port \([0-9]*\) \.\.\.,\1,' < ${test_tmpdir}/httpd-output > ${test_tmpdir}/httpd-port |
There was a problem hiding this comment.
Hmm, that's kinda icky, but yeah we don't want to hardcode a port either just because of that.
|
☀️ Test successful - status-atomicjenkins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I built+installed ostree git master with
ostreedev/ostree#723 in my dev container,
which broke the rpm-ostree tests. Kind of embarrassing that
I forgot to check rpm-ostree for usage of
ostree trivial-httpd.This is another thing that really wants a shared test container.
Anyways let's just use Python for this.