Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experimental compose rootfs #5275

Merged
merged 2 commits into from
Feb 7, 2025
Merged

Conversation

cgwalters
Copy link
Member

The loss of the buildah feature forces us to have a flow like this.

Copy link

openshift-ci bot commented Feb 3, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the idea here that we'd do tree-to-rootfs to get a "conventional rootfs" and then pass that through build-chunked-oci?

rust/src/compose.rs Outdated Show resolved Hide resolved
rust/src/cli_experimental.rs Outdated Show resolved Hide resolved
@cgwalters
Copy link
Member Author

Is the idea here that we'd do tree-to-rootfs to get a "conventional rootfs" and then pass that through build-chunked-oci?

Yep exactly

Copy link
Member

@jmarrero jmarrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

I hit this file being missing.

Signed-off-by: Colin Walters <[email protected]>
The loss of the buildah feature forces us to have a flow like this.

What we output here is an ostree-container aka `bare-split-xattrs`
format.

Signed-off-by: Colin Walters <[email protected]>
@cgwalters cgwalters enabled auto-merge February 6, 2025 22:13
@cgwalters cgwalters changed the title wip: Add experimental compose tree-to-rootfs wip: Add experimental compose rootfs Feb 6, 2025
@cgwalters cgwalters changed the title wip: Add experimental compose rootfs Add experimental compose rootfs Feb 6, 2025
Copy link

openshift-ci bot commented Feb 6, 2025

@cgwalters: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/kola-upgrade 92e033a link true /test kola-upgrade
ci/prow/images 92e033a link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@cgwalters cgwalters merged commit 190b2c2 into coreos:main Feb 7, 2025
15 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants