sysroot: Add total layer count to output #5061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
It's useful to see in the progress output how many layers there are to fetch. This is similar to containers/bootc@6eb5718 which ended up being totally reworked in a nicer way in containers/bootc@d8b5df2 But doing the latter would require nontrivial changes to our DBus API around status and progress reporting...and I'd like to think about how we tackle that more generally in e.g. containers/skopeo#658 Closes: coreos#5024
cgwalters
force-pushed
the
layer-progress-overall
branch
from
0f2c4f8
to
d631211
Compare
|
I think this one just needs a stamp, it's pretty trivial and safe. |
jlebon
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's useful to see in the progress output how many layers there are to fetch.
This is similar to
containers/bootc@6eb5718 which ended up being totally reworked in a nicer way in containers/bootc@d8b5df2
But doing the latter would require nontrivial changes to our DBus API around status and progress reporting...and I'd like to think about how we tackle that more generally in e.g. containers/skopeo#658
Closes: #5024