deployment_utils: Fix version for cached container update #4936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This notably does not fix the |
Previous change used the version of the current deployment instead of the one from the pending container update. Store the new version alongside the manifest diff to be able to return it as part of the cached update logic. Fixes: coreos#4923 Fixes: coreos#4711
travier
force-pushed
the
main-container-update-version
branch
from
5ef5d10 to
5fbb651
Compare
|
I haven't been able to do #4923 (comment) as AFAIU, we don't have the commit in the repo yet as we haven't pulled the container yet? |
Nothing should care about the ostree checksum when using a container image source, basically. |
cgwalters
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
container-update-check: Validate version in manifest diff
deployment_utils: Fix version for cached container update
Previous change used the version of the current deployment instead of
the one from the pending container update.
Store the new version alongside the manifest diff to be able to return
it as part of the cached update logic.
Fixes: #4923
Fixes: #4711