bwrap: Pass mutability flag, not unified core #4863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlebon
approved these changes
Mar 6, 2024
|
Hm, legit CI failure looks like in
Will look |
cgwalters
force-pushed
the
bwrap-cleanup
branch
2 times, most recently
from
de80514 to
487f5e6
Compare
|
Man I stared at this code for a while looking for the problem...but yeah I forgot to regenerate the bindings, which led to just arbitrary undefined behavior here. (Will look at a CI check for this at some point) |
We have two `bool` values here and that's a code smell. I was going to add another option and we definitely don't want three bools. We already have an enum here related to what's going on, so change things to use it. Signed-off-by: Colin Walters <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have two
boolvalues here and that's a code smell. I was going to add another option and we definitely don't want three bools.We already have an enum here related to what's going on, so change things to use it.