cliwrap: make install-to-root idempotent
#4848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, if a system is already cliwrapped, doing `install-to-root` will incorrectly think the already wrapped entrypoints are the real binaries and do the wrong thing. Fix this by checking if the directory holding wrapped binaries already exists. If yes, then no-op. Fixes: coreos/fedora-coreos-tracker#1679
jlebon
added a commit
to jlebon/fedora-coreos-config
that referenced
this pull request
Feb 29, 2024
This reverts commit 3789b06. The reported issue that motivated the revert[[1]] is due to an rpm-ostree bug[[2]]. We can trivially work around this bug until the rpm-ostree fix lands in FCOS, so let's do that and re-enable cliwrap. [1]: coreos/fedora-coreos-tracker#1679 [2]: coreos/rpm-ostree#4848
cgwalters
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, if a system is already cliwrapped, doing
install-to-rootwill incorrectly think the already wrapped entrypoints are the real binaries and do the wrong thing.Fix this by checking if the directory holding wrapped binaries already exists. If yes, then no-op.