Add --compare-with-build to cli #4294
Conversation
This is a prep PR to completing coreos#4247. It allows one to diff the layers of current encapsulated build to any other build.
RishabhSaini
force-pushed
the
compareBuild
branch
from
aee4eb4 to
43bf883
Compare
|
This PR is there to look at the diff in the size of layers between two OCI images. This would be helpful in testing as I need to find which algorithm performs better. |
| Some(compare_with_build) => handle.block_on(async { | ||
| let proxy = containers_image_proxy::ImageProxy::new() | ||
| .await | ||
| .expect("c/img-proxy"); |
There was a problem hiding this comment.
This should use ? here and below.
| match &opt.compare_with_build { | ||
| Some(compare_with_build) => handle.block_on(async { |
There was a problem hiding this comment.
This is more succinct as if let Some(compare_with_build) = opt.compare_with_build.as_ref() {
There was a problem hiding this comment.
Also, let's split the handling here into a separate function.
|
|
||
| /// Compare OCI layers of current build with another(imgref) | ||
| #[clap(name = "compare-with-build", long, short)] | ||
| compare_with_build: Option<String>, |
There was a problem hiding this comment.
I wonder if this is more convenient as a separate CLI command that can take two arbitrary builds? i.e. rpm-ostree container compare-images? Or hmm, I guess if we're keeping it independent of RPM content it could live in ostree even as ostree container compare-images or so?
| let removed_size_str = glib::format_size(removed_size); | ||
| let added_size = layersum(&diff.removed); | ||
| let added_size_str = glib::format_size(added_size); | ||
| println!("Total new layers: {new_total} Size: {new_total_size}"); |
There was a problem hiding this comment.
Would also make sense to have a handy fn print(&self) on ManifestDiff I think so we can share this code with the compose path.
|
|
This is a prep PR to completing #4247. It allows one to diff the layers of current encapsulated build to any other build.