Json parse prep #1580
Closed
Json parse prep #1580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prep for further changes.
Prep for moving more of our parsing into Rust. The main thing here is that for JSON, we need to continue to ignore unknown fields. It took me a little while but I eventually figured out that using `#[serde(flatten)]` works for this. Seriously: serde is freaking amazingly awesome.
jlebon
reviewed
Sep 26, 2018
| )) | ||
| fn treefile_parse_stream( | ||
| fmt: InputFormat, | ||
| input: &mut io::Read, |
There was a problem hiding this comment.
Minor: why the switch away from a generic here? Seems fine either way, just want to understand the motivation.
There was a problem hiding this comment.
There were like 2-3 rewrites/false starts here before this patch got split out as a prep for the bigger PR. I don't think there was any deliberate reason, and it does make sense to me to avoid vfuncs here.
|
⚡ Test exempted: pull fully rebased and already tested. |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Sep 26, 2018
Prep for moving more of our parsing into Rust. The main thing here is that for JSON, we need to continue to ignore unknown fields. It took me a little while but I eventually figured out that using `#[serde(flatten)]` works for this. Seriously: serde is freaking amazingly awesome. Closes: #1580 Approved by: jlebon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.