Split bindgen to separate build #1573
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Aside from still needing to touch the vendoring code, this was a surprisingly painless patch) |
jlebon
reviewed
Sep 24, 2018
Makefile-rpm-ostree.am
Outdated
| cd $(top_srcdir)/bindgen && \ | ||
| export CARGO_TARGET_DIR=@abs_top_builddir@/bindgen-target && \ | ||
| $(cargo) build --verbose && \ | ||
| ln -sf $${CARGO_TARGET_DIR}/debug/rpmostree-bindgen $(abs_top_builddir)/rpmostree-bindgen |
There was a problem hiding this comment.
Minor: looks like inconsistent spacing?
The problem is building bindgen as part of our single run locks serde to way old versions, and I want to use newer versions. Since Fedora will now again ship a `cbindgen` package, let's also support using it if we find it, saving ourselves the cost of building it. For distros that don't ship it (e.g. CentOS) for CI purposes we build it. For downstream builds that are offline, rather than vendor the cbindgen sources like we do with our main Rust, let's just vendor the `rpmostree-rust.h` file as was suggested in https://bugzilla.redhat.com/show_bug.cgi?id=1608670 Closes: coreos#1557
cgwalters
force-pushed
the
split-bindgen
branch
from
6813d4e to
08c4db6
Compare
|
OK, I reworked this. We now save |
jlebon
reviewed
Sep 25, 2018
rh-atomic-bot
pushed a commit
that referenced
this pull request
Sep 25, 2018
The problem is building bindgen as part of our single run locks serde to way old versions, and I want to use newer versions. Since Fedora will now again ship a `cbindgen` package, let's also support using it if we find it, saving ourselves the cost of building it. For distros that don't ship it (e.g. CentOS) for CI purposes we build it. For downstream builds that are offline, rather than vendor the cbindgen sources like we do with our main Rust, let's just vendor the `rpmostree-rust.h` file as was suggested in https://bugzilla.redhat.com/show_bug.cgi?id=1608670 Closes: #1557 Closes: #1573 Approved by: jlebon
|
💔 Test failed - status-atomicjenkins |
|
@rh-atomic-bot retry |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Sep 25, 2018
The problem is building bindgen as part of our single run locks serde to way old versions, and I want to use newer versions. Since Fedora will now again ship a `cbindgen` package, let's also support using it if we find it, saving ourselves the cost of building it. For distros that don't ship it (e.g. CentOS) for CI purposes we build it. For downstream builds that are offline, rather than vendor the cbindgen sources like we do with our main Rust, let's just vendor the `rpmostree-rust.h` file as was suggested in https://bugzilla.redhat.com/show_bug.cgi?id=1608670 Closes: #1557 Closes: #1573 Approved by: jlebon
|
💔 Test failed - status-atomicjenkins |
|
😢 @rh-atomic-bot retry |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Sep 25, 2018
The problem is building bindgen as part of our single run locks serde to way old versions, and I want to use newer versions. Since Fedora will now again ship a `cbindgen` package, let's also support using it if we find it, saving ourselves the cost of building it. For distros that don't ship it (e.g. CentOS) for CI purposes we build it. For downstream builds that are offline, rather than vendor the cbindgen sources like we do with our main Rust, let's just vendor the `rpmostree-rust.h` file as was suggested in https://bugzilla.redhat.com/show_bug.cgi?id=1608670 Closes: #1557 Closes: #1573 Approved by: jlebon
|
💔 Test failed - status-atomicjenkins |
|
I believe in you, Homu! |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Sep 25, 2018
The problem is building bindgen as part of our single run locks serde to way old versions, and I want to use newer versions. Since Fedora will now again ship a `cbindgen` package, let's also support using it if we find it, saving ourselves the cost of building it. For distros that don't ship it (e.g. CentOS) for CI purposes we build it. For downstream builds that are offline, rather than vendor the cbindgen sources like we do with our main Rust, let's just vendor the `rpmostree-rust.h` file as was suggested in https://bugzilla.redhat.com/show_bug.cgi?id=1608670 Closes: #1557 Closes: #1573 Approved by: jlebon
|
💔 Test failed - status-atomicjenkins |
|
@rh-atomic-bot retry |
|
☀️ Test successful - status-atomicjenkins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is building bindgen as part of our single run
locks serde to way old versions, and I want to use newer versions.
This also opens the door to potentially using an external
bindgenbinary if available (as it likely will be soon in Fedora again).
Oh and I know this totally doesn't work with the vendoring
code yet...
Closes: #1557