bwrap: Use rofiles-fuse --copyup by default #1171
Conversation
|
Requires ostreedev/ostree#1382 |
This fixes a large swath of compatibility issues, for the same reasons as overlayfs makes a lot of things Just Work. The ugly part of course is doing hidden copyups inside the filesystem. We've gone quite a long time with the "pure rofiles" mode, and have made changes to various bits of userspace to be compatible with it. But what finally made me give up on that is glibc's locale-archive; there's a patch for it that is stalled, but even if it was applied we would still need to work with older glibc. This issue comes to the fore in unified core 🌐 mode, as without this we won't get a correct locale archive.
cgwalters
force-pushed
the
rofiles-copyup
branch
from
0ca9381 to
708a0a9
Compare
|
Rebased 🏄♂️ and with tests ✅ |
|
LGTM, though:
Looking in the journal:
Looks like a difference between CentOS and Fedora AH: vs |
| test_overwritepath= | ||
| for path in /usr/share/licenses/glibc/COPYING | ||
| /usr/share/systemd/kbd-model-map | ||
| /usr/share/rpm-ostree/treefile.json; do |
There was a problem hiding this comment.
Hmm, these lines need to have their newlines escaped, no?
Let's just use /usr/share/rpm-ostree/treefile.json for all cases?
|
☀️ Test successful - status-papr |
This fixes a large swath of compatibility issues, for the same reasons as
overlayfs makes a lot of things Just Work. The ugly part of course is
doing hidden copyups inside the filesystem.
We've gone quite a long time with the "pure rofiles" mode, and have made changes
to various bits of userspace to be compatible with it. But what finally made me
give up on that is glibc's locale-archive; there's a patch for it that
is stalled, but even if it was applied we would still need to work with
older glibc.
This issue comes to the fore in unified core 🌐 mode, as without this
we won't get a correct locale archive.