core: Implement parallel importing #1124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
☔ The latest upstream changes (presumably 694b798) made this pull request unmergeable. Please resolve the merge conflicts. |
Now that the importer *only* imports into OSTree repos, let's clean up the API so that the `OstreeRepo` and `OstreeSePolicy` are passed as constructor args. Also rework things so there's only one constructor API that steals the fd. This is prep for adding another async import API.
Depends: ostreedev/ostree#1358 For jigdo ♲📦 in order to get true image speed like libostree has we need to interleave and parallelize downloading and importing. The messy part about this is having sync API do the "invoke and wait on various async tasks" pattern. It's the same thing in `ostree_repo_pull_with_options()`. Importing is pretty dramatically faster with this, I can only imagine the speed win if we actually interleaved with downloads. However doing that requires libdnf/librepo work.
cgwalters
force-pushed
the
parallel-import
branch
from
ab7012f to
2b979f6
Compare
jlebon
reviewed
Dec 5, 2017
src/libpriv/rpmostree-core.c
Outdated
| GMainContext *mainctx = g_main_context_get_thread_default (); | ||
| while (self->async_running) | ||
| g_main_context_iteration (mainctx, TRUE); | ||
| if (self->async_error) |
There was a problem hiding this comment.
We have to propagate the error here, right?
src/libpriv/rpmostree-core.c
Outdated
| if (!rev) | ||
| { | ||
| self->async_running = FALSE; | ||
| self->async_error_set = TRUE; |
There was a problem hiding this comment.
Let's g_assert (self->async_error) here?
|
Registry is probably still borked, though let's give it a try. |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Dec 5, 2017
Now that the importer *only* imports into OSTree repos, let's clean up the API so that the `OstreeRepo` and `OstreeSePolicy` are passed as constructor args. Also rework things so there's only one constructor API that steals the fd. This is prep for adding another async import API. Closes: #1124 Approved by: jlebon
rh-atomic-bot
pushed a commit
that referenced
this pull request
Dec 5, 2017
Depends: ostreedev/ostree#1358 For jigdo ♲📦 in order to get true image speed like libostree has we need to interleave and parallelize downloading and importing. The messy part about this is having sync API do the "invoke and wait on various async tasks" pattern. It's the same thing in `ostree_repo_pull_with_options()`. Importing is pretty dramatically faster with this, I can only imagine the speed win if we actually interleaved with downloads. However doing that requires libdnf/librepo work. Closes: #1124 Approved by: jlebon
|
💔 Test failed - status-atomicjenkins |
Closed
|
@rh-atomic-bot retry |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Dec 7, 2017
Depends: ostreedev/ostree#1358 For jigdo ♲📦 in order to get true image speed like libostree has we need to interleave and parallelize downloading and importing. The messy part about this is having sync API do the "invoke and wait on various async tasks" pattern. It's the same thing in `ostree_repo_pull_with_options()`. Importing is pretty dramatically faster with this, I can only imagine the speed win if we actually interleaved with downloads. However doing that requires libdnf/librepo work. Closes: #1124 Approved by: jlebon
|
☀️ Test successful - status-atomicjenkins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note this PR is on top of jigdo since otherwise it'd conflict.
Depends: ostreedev/ostree#1358
For jigdo ♲📦 in order to get true image speed like libostree has we need to
interleave and parallelize downloading and importing.
The messy part about this is having sync API do the "invoke and wait on various
async tasks" pattern. It's the same thing in
ostree_repo_pull_with_options().Importing is pretty dramatically faster with this, I can only imagine the speed
win if we actually interleaved with downloads. However doing that requires
libdnf/librepo work.