status: Render ostree metadata source-title key #1069
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bot, retest this please |
cgwalters
force-pushed
the
commit-source-title
branch
from
6cc4b0b to
226e7f0
Compare
|
I reworked this on top of a prep commit that passes through the (ostree) commit metadata in a more generic way ⬆️ |
jlebon
reviewed
Oct 24, 2017
There was a problem hiding this comment.
Hmm, test-basic.sh is being scary: 👻
**
GLib:ERROR:gvarianttypeinfo.c:163:g_variant_type_info_check: assertion failed: (info->alignment == 0 || info->alignment == 1 || info->alignment == 3 || info->alignment == 7)
/var/tmp/checkout/tests/check/test-basic.sh: line 52: 18686 Aborted (core dumped) rpm-ostree status > status.txt
ok status shows right version
| * of the commit metadata. | ||
| */ | ||
| { g_autoptr(GVariant) base_meta = g_variant_get_child_value (commit, 0); | ||
| g_variant_dict_insert (&dict, "commit-meta", "@a{sv}", base_meta); |
There was a problem hiding this comment.
Minor: let's call this base-commit-meta and the other one simply commit-meta to be more consistent?
There was a problem hiding this comment.
I was thinking that now that we're de-emphasizing the final commit a bit, using the more explicit naming for "base"/"layered" is clearer. So perhaps change this key to "base-commit-meta"?
In another PR I did the manual bridging of commit metadata to deployment property, but that's annoying. Let's just bridge all commit metadata.
Depends: ostreedev/ostree#1296 As I mention in the commit there, I see two uses for this in rpm-ostree; first in our test suite, and second for OCI-built image imports. I also took a step further here and inject an `original-origin` metadata key, though we aren't actually using that yet. The problem I'm trying to solve there is that repeated `make vmoverlay` starts chaining things up, but that gets very confusing. I think we should always have `vmoverlay` unwind back to the base ref. (Or at least do that by default)
cgwalters
force-pushed
the
commit-source-title
branch
from
226e7f0 to
92d3311
Compare
rh-atomic-bot
pushed a commit
that referenced
this pull request
Oct 25, 2017
Depends: ostreedev/ostree#1296 As I mention in the commit there, I see two uses for this in rpm-ostree; first in our test suite, and second for OCI-built image imports. I also took a step further here and inject an `original-origin` metadata key, though we aren't actually using that yet. The problem I'm trying to solve there is that repeated `make vmoverlay` starts chaining things up, but that gets very confusing. I think we should always have `vmoverlay` unwind back to the base ref. (Or at least do that by default) Closes: #1069 Approved by: jlebon
|
☀️ Test successful - status-atomicjenkins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends: ostreedev/ostree#1296
As I mention in the commit there, I see two uses for this in rpm-ostree; first
in our test suite, and second for OCI-built image imports.
I also took a step further here and inject an
original-originmetadatakey, though we aren't actually using that yet. The problem I'm trying
to solve there is that repeated
make vmoverlaystarts chaining things up,but that gets very confusing. I think we should always have
vmoverlayunwindback to the base ref. (Or at least do that by default)