app: Unify some cmdline txn processing #1034
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bot, retest this please |
|
☔ The latest upstream changes (presumably 025633a) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Looks good to me! Just needs a rebase. |
We had duplicated code across the cmdline entrypoints for transaction processing; things like "print pkg diff only if !opt_reboot". This doesn't dedup all of them - there are some corner cases around the preview logic in `upgrade`, and `initramfs` also need special handling. I'll likely enhance this further down the line for that. But one reason I'm doing this now is prep for: [rpm-ostree cancel](coreos#1019) Basically, I want to add a `-B/--background` option we honor consistently, and that'd be a lot easier if we have a combined "start/monitor txn" with the post-txn option processing in one place.
cgwalters
force-pushed
the
txn-client-cleanup
branch
from
f2c73d7 to
5c80fbc
Compare
|
Rebased 🏄 |
|
☀️ Test successful - status-atomicjenkins |
jlebon
added a commit
to jlebon/rpm-ostree
that referenced
this pull request
Oct 5, 2017
It's no longer being built and is now older than the latest CentOS AH release. This should help us no longer see messages like: (rpm-ostree pkg-add:5662): GLib-CRITICAL **: g_variant_dict_lookup: assertion 'is_valid_dict (dict)' failed which happen because in coreos#1034, we started using `G_VARIANT_DICT_INIT`, whose special magic values only make sense in glib2 >= 2.50. (The alpha image stopped at 2.46). Saw this while debugging coreos#1035.
rh-atomic-bot
pushed a commit
that referenced
this pull request
Oct 6, 2017
It's no longer being built and is now older than the latest CentOS AH release. This should help us no longer see messages like: (rpm-ostree pkg-add:5662): GLib-CRITICAL **: g_variant_dict_lookup: assertion 'is_valid_dict (dict)' failed which happen because in #1034, we started using `G_VARIANT_DICT_INIT`, whose special magic values only make sense in glib2 >= 2.50. (The alpha image stopped at 2.46). Saw this while debugging #1035. Closes: #1040 Approved by: cgwalters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had duplicated code across the cmdline entrypoints for transaction
processing; things like "print pkg diff only if !opt_reboot".
This doesn't dedup all of them - there are some corner cases around
the preview logic in
upgrade, andinitramfsalso need specialhandling. I'll likely enhance this further down the line for that.
But one reason I'm doing this now is prep for:
rpm-ostree cancel
Basically, I want to add a
-B/--backgroundoption we honor consistently, andthat'd be a lot easier if we have a combined "start/monitor txn" with the
post-txn option processing in one place.