Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libpriv/postprocess: also delete semanage lock files #1002

Closed
wants to merge 2 commits into from
Closed

libpriv/postprocess: also delete semanage lock files #1002

wants to merge 2 commits into from

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Sep 19, 2017

We don't need those in the tree, so let's nuke them. This also fixes
subtle compatibility issues between hardlinks and lock files (see #999).

@jlebon
libpriv/postprocess: also delete semanage lock files
0521802 
We don't need those in the tree, so let's nuke them. This also fixes
subtle compatibility issues between hardlinks and lock files (see coreos#999).
@jlebon jlebon force-pushed the pr/delete-lock-files branch from f236479 to 0521802 Compare September 19, 2017 19:26
@jlebon jlebon changed the title src/libpriv: also delete semanage lock files libpriv/postprocess: also delete semanage lock files Sep 19, 2017
@cgwalters
Copy link
Member

@rh-atomic-bot r+ 0521802

@rh-atomic-bot
Copy link

⌛ Testing commit 0521802 with merge 3b255bd...

rh-atomic-bot pushed a commit that referenced this pull request Sep 19, 2017
@jlebon @rh-atomic-bot
libpriv/postprocess: also delete semanage lock files
3b255bd 
We don't need those in the tree, so let's nuke them. This also fixes
subtle compatibility issues between hardlinks and lock files (see #999).

Closes: #1002
Approved by: cgwalters
@jlebon
Copy link
Member Author

jlebon commented Sep 19, 2017

The tester went for down for a sec, it should be back online now.
@rh-atomic-bot retry

@rh-atomic-bot
Copy link

⌛ Testing commit 0521802 with merge 089623d...

rh-atomic-bot pushed a commit that referenced this pull request Sep 19, 2017
@jlebon @rh-atomic-bot
libpriv/postprocess: also delete semanage lock files
089623d 
We don't need those in the tree, so let's nuke them. This also fixes
subtle compatibility issues between hardlinks and lock files (see #999).

Closes: #1002
Approved by: cgwalters
@jlebon
Copy link
Member Author

jlebon commented Sep 19, 2017

@rh-atomic-bot retry

@rh-atomic-bot
Copy link

⌛ Testing commit 0521802 with merge 504bdf4...

rh-atomic-bot pushed a commit that referenced this pull request Sep 19, 2017
@jlebon @rh-atomic-bot
libpriv/postprocess: also delete semanage lock files
504bdf4 
We don't need those in the tree, so let's nuke them. This also fixes
subtle compatibility issues between hardlinks and lock files (see #999).

Closes: #1002
Approved by: cgwalters
@cgwalters
Copy link
Member

@rh-atomic-bot retry

@rh-atomic-bot
Copy link

⌛ Testing commit 0521802 with merge d5d8868...

rh-atomic-bot pushed a commit that referenced this pull request Sep 20, 2017
@jlebon @rh-atomic-bot
libpriv/postprocess: also delete semanage lock files
d5d8868 
We don't need those in the tree, so let's nuke them. This also fixes
subtle compatibility issues between hardlinks and lock files (see #999).

Closes: #1002
Approved by: cgwalters
@rh-atomic-bot
Copy link

💔 Test failed - status-atomicjenkins

@cgwalters
Copy link
Member

Needs to handle ENOENT for the selinux dir for the container/buildroot case; potentially we could detect whether selinux: true in the manifest?

error: Opening /usr/etc/selinux: opendir(usr/etc/selinux): No such file or directory

@jlebon
Copy link
Member Author

jlebon commented Sep 20, 2017

Fixup to handle ENOENT! ⬆️

potentially we could detect whether selinux: true in the manifest?

Although, we also go through this path during layering, right?

@jlebon jlebon mentioned this pull request Sep 20, 2017
Closed
@cgwalters
Copy link
Member

Although, we also go through this path during layering, right?

Yep, though it might be nice to start thinking about putting the treefile data in the commit so we can do things like match documentation too. But eh.

@cgwalters
Copy link
Member

@rh-atomic-bot r+ dbca3c9

@rh-atomic-bot
Copy link

⌛ Testing commit dbca3c9 with merge 684c60c...

rh-atomic-bot pushed a commit that referenced this pull request Sep 21, 2017
@jlebon @rh-atomic-bot
libpriv/postprocess: also delete semanage lock files
684c60c 
We don't need those in the tree, so let's nuke them. This also fixes
subtle compatibility issues between hardlinks and lock files (see #999).

Closes: #1002
Approved by: cgwalters
@rh-atomic-bot
Copy link

💔 Test failed - status-atomicjenkins

@cgwalters
Copy link
Member

@rh-atomic-bot retry

@rh-atomic-bot
Copy link

⌛ Testing commit dbca3c9 with merge e6d9975...

rh-atomic-bot pushed a commit that referenced this pull request Sep 21, 2017
@jlebon @rh-atomic-bot
libpriv/postprocess: also delete semanage lock files
e6d9975 
We don't need those in the tree, so let's nuke them. This also fixes
subtle compatibility issues between hardlinks and lock files (see #999).

Closes: #1002
Approved by: cgwalters
@jlebon
Copy link
Member Author

jlebon commented Sep 21, 2017

@rh-atomic-bot retry

@rh-atomic-bot
Copy link

⌛ Testing commit dbca3c9 with merge f089b8d...

@rh-atomic-bot
Copy link

☀️ Test successful - status-atomicjenkins
Approved by: cgwalters
Pushing f089b8d to master...

@jlebon jlebon deleted the pr/delete-lock-files branch October 3, 2017 18:59
@jlebon jlebon mentioned this pull request Oct 10, 2018
Closed
cgwalters added a commit to cgwalters/rpm-ostree that referenced this pull request Oct 10, 2018
@cgwalters
importer: Don't import libselinux .LOCK files
1585b04 
These shouldn't be in the package; the fact that they're empty
files causes libostree to hardlink them which breaks things.
See also coreos#1002
cgwalters added a commit to cgwalters/rpm-ostree that referenced this pull request Oct 10, 2018
@cgwalters
importer: Don't import libselinux .LOCK files
465711e 
These shouldn't be in the package; the fact that they're empty
files causes libostree to hardlink them which breaks things.
See also coreos#1002
cgwalters added a commit to cgwalters/rpm-ostree that referenced this pull request Oct 11, 2018
@cgwalters
importer: Don't import libselinux .LOCK files
f7b027f 
These shouldn't be in the package; the fact that they're empty
files causes libostree to hardlink them which breaks things.
See also coreos#1002
cgwalters added a commit to cgwalters/rpm-ostree that referenced this pull request Oct 12, 2018
@cgwalters
importer: Don't import libselinux .LOCK files
4c60688 
These shouldn't be in the package; the fact that they're empty
files causes libostree to hardlink them which breaks things.
See also coreos#1002
rh-atomic-bot pushed a commit that referenced this pull request Oct 12, 2018
@cgwalters @rh-atomic-bot
importer: Don't import libselinux .LOCK files
d2d7cce 
These shouldn't be in the package; the fact that they're empty
files causes libostree to hardlink them which breaks things.
See also #1002

Closes: #1591
Approved by: jlebon
rh-atomic-bot pushed a commit that referenced this pull request Oct 12, 2018
@cgwalters @rh-atomic-bot
importer: Don't import libselinux .LOCK files
4b6040b 
These shouldn't be in the package; the fact that they're empty
files causes libostree to hardlink them which breaks things.
See also #1002

Closes: #1591
Approved by: jlebon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
reviewed/approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jlebon @cgwalters @rh-atomic-bot