upgrade --check supported or not?

[puiterwijk]

[root@conex puiterwijk]# rpm-ostree upgrade --help
Usage:
rpm-ostree upgrade [OPTION...] - Perform a system upgrade

Help Options:
-h, --help Show help options

Application Options:
--os=OSNAME Operate on provided OSNAME
-r, --reboot Initiate a reboot after an upgrade is prepared
--allow-downgrade Permit deployment of chronologically older trees
--preview Just preview package differences
--check Just check if an upgrade is available
--upgrade-unchanged-exit-77 If no upgrade is available, exit 77
--sysroot=SYSROOT Use system root SYSROOT (default: /)
--peer Force a peer-to-peer connection instead of using the system message bus
--version Print version information and exit

[root@conex puiterwijk]# rpm-ostree uprade --check
Usage:
rpm-ostree [OPTION...] COMMAND

Builtin Commands:
compose
db
deploy
rebase
rollback
status
upgrade

Help Options:
-h, --help Show help options

Application Options:
--version Print version information and exit

error: Unknown option --check

** (rpm-ostree:32710): WARNING **: (src/app/main.c:296):main: runtime check failed: (exit_status != EXIT_SUCCESS)

[puiterwijk]

Sorry, I was unable to type. Second type was a typo.
But it would be useful if instead of "unknown option --check", it would have reported "unknown action 'uprade'" or something.

[miabbott]

FWIW, @cgwalters fixed that ugly WARNING message in #262

Not sure if that would cause the command to return properly like if you just typed rpm-ostree foo, with out the --check like so:

$ rpm-ostree foobar
Usage:
  rpm-ostree [OPTION...] COMMAND

Builtin Commands:
  compose
  db
  deploy
  rebase
  rollback
  status
  upgrade

Help Options:
  -h, --help       Show help options

Application Options:
  --version        Print version information and exit

error: Unknown command 'foobar'