Skip to content

Commit

Permalink
upgrade: Print changed packages again
Browse files Browse the repository at this point in the history
First I noticed we needed to query the new default *after* the
transaction had run.  Then, I noticed the obvious embarassing logic
error.

Fixes: 3f1e7c85a18182669899f4065d23fec6ac0962c
Closes: #396

Closes: #397
Approved by: jlebon
  • Loading branch information
cgwalters authored and rh-atomic-bot committed Jul 18, 2016
1 parent 64c6f8d commit 454139d
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/app/rpmostree-builtin-upgrade.c
Original file line number Diff line number Diff line change
Expand Up @@ -129,14 +129,14 @@ rpmostree_builtin_upgrade (int argc,
goto out;
}

new_default_deployment = rpmostree_os_dup_default_deployment (os_proxy);

if (!rpmostree_transaction_get_response_sync (sysroot_proxy,
transaction_address,
cancellable,
error))
goto out;

new_default_deployment = rpmostree_os_dup_default_deployment (os_proxy);

if (opt_preview || opt_check)
{
g_autoptr(GVariant) result = NULL;
Expand Down Expand Up @@ -169,7 +169,7 @@ rpmostree_builtin_upgrade (int argc,
if (previous_default_deployment == new_default_deployment)
changed = FALSE;
else
changed = g_variant_equal (previous_default_deployment, new_default_deployment);
changed = !g_variant_equal (previous_default_deployment, new_default_deployment);

if (!changed)
{
Expand Down

0 comments on commit 454139d

Please sign in to comment.