capnslog: add LogDepth to PackageLogger #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to enable wrapping capnslog with custom logging helpers where you would need to control the caller depth.
|
On the one hand, I have no problem with it. On the other, this pushes writing, eg, Do you have a quick wrapper example, @betawaffle ? |
|
After writing a custom formatter, which I did today, I'm much less certain. Perhaps what's needed instead are some good examples of Entry objects a user could create. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to be able to wrap capnslog with convenience functions and application-specific helpers, but I need to be able to control the caller depth. This change makes that possible.