This repository has been archived by the owner on Feb 11, 2021. It is now read-only.
cluster/images/hyperkube: add jq for some volume plugins #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Let's take this upstream too. If you don't intend to, I'd be happy to make the PR. |
|
@euank: Go for it, your a more familiar face so it will probably get merged faster, thanks. |
|
Wow, that was fast, kubernetes#38793 is merged. We can still carry this for a little depending if that makes it into the next 1.5.X release or not. |
|
Since carrying this is fairly painless I don't have an intention of requesting a cherry pick. |
|
SGTM |
|
also lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for coreos/bugs#1706